-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nproc #204
fix nproc #204
Conversation
✅ Deploy Preview for startling-capybara-2231ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@GitGab19 can you review this one when you get a chance please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the binaries for the TP provided by Sjors in our guide?
https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.2
could be a good alternative to making people build their own TP, perhaps a new PR going in this direction could replace this one but I would point them to the release page (as a general step), not one specific release that would avoid the need for future PRs updating the instructions whenever new releases come out |
Yeah I totally agree on the approach 👍 |
Agreed it is easier with TP binaries. Do we want to do those TP changes in this PR @plebhash ? |
done |
@plebhash Yes linkcheck, Twitter blocks it so it fails, it's always safe to proceed if linkcheck fails at twitter links. |
close #203